Add network support to flux_led discovery#61132
Merged
balloob merged 5 commits intohome-assistant:devfrom Dec 19, 2021
Merged
Conversation
|
Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration ( |
22 tasks
9f0f8bb to
3ff1fe4
Compare
22 tasks
3ff1fe4 to
8631755
Compare
Member
Author
|
Looks like I need to fix the conflicts better |
7a71678 to
d81300b
Compare
Member
Author
|
I can't get this to pass the CI even though it does locally due to the codecov. Will try a rebase |
Member
Author
|
rebase fixed the CI issue |
22 tasks
balloob
approved these changes
Dec 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add network support to flux_led discovery
The scanner is now aware of multiple network interfaces (already updated in another PR to fix a bug in music mode)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: