Skip to content

Add network support to flux_led discovery#61132

Merged
balloob merged 5 commits intohome-assistant:devfrom
bdraco:flux_led_network_discovery
Dec 19, 2021
Merged

Add network support to flux_led discovery#61132
balloob merged 5 commits intohome-assistant:devfrom
bdraco:flux_led_network_discovery

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 6, 2021

Proposed change

Add network support to flux_led discovery

The scanner is now aware of multiple network interfaces (already updated in another PR to fix a bug in music mode)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 10, 2021

Looks like I need to fix the conflicts better

@bdraco bdraco force-pushed the flux_led_network_discovery branch from 7a71678 to d81300b Compare December 10, 2021 22:01
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 10, 2021

I can't get this to pass the CI even though it does locally due to the codecov.

Will try a rebase

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 10, 2021

rebase fixed the CI issue

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Dec 11, 2021
@balloob balloob merged commit a4c101b into home-assistant:dev Dec 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests integration: flux_led smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading to 2021.11.1 - getting [flux_led.aioscanner] LEDENETDiscovery error: [WinError 10022] An invalid argument was supplied

3 participants